Skip to content

Conversation

@jtpio
Copy link
Member

@jtpio jtpio commented Dec 31, 2021

As noticed in jupyterlab/jupyterlab#11770, recent versions of setuptools have switched to the Python logging infrastructure to log messages. Which means the output of python setup.py --version might now contain other messages than just the version.

This is not an issue when using the releaser for now, as there is a pin on setuptools here:

setuptools~=57.0

Similar to #37, this changes proposes to parse the last line of the python setup.py --version command only.

@jtpio jtpio added the enhancement New feature or request label Dec 31, 2021
@jtpio jtpio added this to the 0.10 milestone Dec 31, 2021
@jtpio
Copy link
Member Author

jtpio commented Dec 31, 2021

Investigating CI failures in #232

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 6b92784 into jupyter-server:main Dec 31, 2021
@jtpio jtpio deleted the python-version branch January 1, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants