Only create ThreadGroups if FailOnTimeout.lookForStuckThread is true. #1691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the differences (where possible) when tests are run with a timeout. Creating a ThreadGroup can cause noticeable differences, for example in code that uses java.beans.ThreadGroupContext.
marcphilipp
approved these changes
Jan 3, 2021
src/main/java/org/junit/internal/runners/statements/FailOnTimeout.java
Outdated
Show resolved
Hide resolved
stefanbirkner
approved these changes
Jan 3, 2021
Contributor
stefanbirkner
left a comment
stefanbirkner
left a comment
There was a problem hiding this comment.
Nice catch and thanks for explaining the details in the comments.
stefanbirkner
approved these changes
Jan 3, 2021
kcooney
force-pushed
the
use-threadgroup-judiciously
branch
from
d5f0bf1 to
a501477
Compare
Member
Author
|
I updated this pull so that the release notes documents the change. @marcphilipp and/or @stefanbirkner would you please review the release notes? Thanks! |
marcphilipp
approved these changes
Jan 5, 2021
stefanbirkner
approved these changes
Jan 6, 2021
This was referenced Mar 15, 2021
This was referenced May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the differences (where possible) when tests are run with a timeout.
Creating a ThreadGroup can cause noticeable differences, for example in code
that uses java.beans.ThreadGroupContext.