Skip to content

Fix non-browser usage #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ClassicOldSong
Copy link

Fix usage in non-browser environments.

@juliangarnier
Copy link
Owner

Are you sure the current implementation doesn't work in non-browser environments?
I can target an Object in Node without issue at the moment.
Does this PR solves #1017 ?
Thanks!!

@ClassicOldSong
Copy link
Author

ClassicOldSong commented Jul 31, 2025

If you pass in an array of objects, it tries to find DOM nodes in non browser environments.

The isUnd(Intl) is a pure usage error.

I don't think this fixes ReactNative, because it has window on global but not document and all other browser specific features.

@ClassicOldSong
Copy link
Author

IDK if you remember this:

https://x.com/classicoldsong/status/1635238486549864448

I'm still working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants