DraggableParams are not exported

[SikandarJODD]

Describe the bug

DraggableParams are not exported in index.d.ts file

Expected behavior

• While using createDraggable in a Svelte project, I tried to import DraggableParams, but it seems to be missing.

• Just like we have AnimationParams exported, I was expecting to find DraggableParams as well.
  Is this omission intentional, or could it be an oversight?

Screenshots

Proposed Solution

It would be helpful to export DraggableParams from the index.d.ts file so it can be used externally.

[juliangarnier]

The problem is that I don't know how to mark a JSDoc type definition as "exportable“ by the generated index.d.ts file.

Would love some help on this!

[AdeboyeDN]

I ran into similar issue, i would like to work on it

[juliangarnier]

I ran into similar issue, i would like to work on it

Would love some help on this, are you familiar with JSDoc to TS types conversion?

[AdeboyeDN]

I ran into similar issue, i would like to work on it

Would love some help on this, are you familiar with JSDoc to TS types conversion?

yes, i am very familiar with jsDocs and ts types

[juliangarnier]

Great, at the moment there are two issues related to types, this one and #972.

Would love your input on this, or feel free to open a PR if you're confident in what should be changed.

I'm also open to suggestion to update the rollup config, since I'm currently using the deprecated rollup-plugin-ts plugin, and didn't have the time to figure out how to get the same easy automatic JSDoc comments to index.d.ts file conversion with the suggested replacements @rollup/plugin-typescript and rollup-plugin-dts plugins.

Let me know if you have any questions!

[AdeboyeDN]

Great, at the moment there are two issues related to types, this one and #972.

Would love your input on this, or feel free to open a PR if you're confident in what should be changed.

I'm also open to suggestion to update the rollup config, since I'm currently using the deprecated rollup-plugin-ts plugin, and didn't have the time to figure out how to get the same easy automatic JSDoc comments to index.d.ts file conversion with the suggested replacements @rollup/plugin-typescript and rollup-plugin-dts plugins.

Let me know if you have any questions!

Alright I will look into that too, Thanks

[AdeboyeDN]

Great, at the moment there are two issues related to types, this one and #972.

Would love your input on this, or feel free to open a PR if you're confident in what should be changed.

I'm also open to suggestion to update the rollup config, since I'm currently using the deprecated rollup-plugin-ts plugin, and didn't have the time to figure out how to get the same easy automatic JSDoc comments to index.d.ts file conversion with the suggested replacements @rollup/plugin-typescript and rollup-plugin-dts plugins.

Let me know if you have any questions!

Alright I will look into that too, Thanks

Hello,I noticed there's a gui/gui.js in the rollup config and it does not exist, any idea on what it is?

[juliangarnier]

Hello,I noticed there's a gui/gui.js in the rollup config and it does not exist, any idea on what it is?

You can comment this, it's leftovers from the beta version. It's already fixed on the dev branch.

[AdeboyeDN]

Hello,I noticed there's a gui/gui.js in the rollup config and it does not exist, any idea on what it is?

You can comment this, it's leftovers from the beta version. It's already fixed on the dev branch.

Opened a PR to add types for DraggableParams #1004 .

I wasn’t able to reproduce the issue described in #972 , as spread parameters should be optional by default.

It might be an issue with the plugin used by the user, but there wasn’t enough information provided about the error to confirm this.

Also, since rollup-plugin-dts is now in maintenance mode, it would be better to migrate this to TypeScript. This way, types can be generated easily without relying on additional plugins.

[juliangarnier]

Fixed in v4.0.2