Enable text-only vector search #1430
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Feedback 🧐(Feedback updated until commit 246f3a2)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
Ahmad-mtos
reviewed
Jul 9, 2025
Comment on lines
+43
to
+56
| if not search_params.text: | ||
| raise HTTPException(status_code=400, detail="text is required for vector search") | ||
| [search_params.vector, *_] = await litellm.aembedding( | ||
| inputs=search_params.text, | ||
| embed_instruction="Represent the query for retrieving supporting documents: ", | ||
| user=str(x_developer_id), | ||
| ) | ||
|
|
||
| if isinstance(search_params, HybridDocSearchRequest) and search_params.vector is None: | ||
| [search_params.vector, *_] = await litellm.aembedding( | ||
| inputs=search_params.text, | ||
| embed_instruction="Represent the query for retrieving supporting documents: ", | ||
| user=str(x_developer_id), | ||
| ) |
There was a problem hiding this comment.
wouldn't the addition of the text field mess up the union type for search_param parameter? By introducing text to the vector search and making vector field optional.
A suggestion would be adding a mode field to all search types to specify what type to use while searching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
ruff format agents-api/agents_api/routers/docs/search_docs.py agents-api/tests/test_docs_routes.py agents-api/agents_api/autogen/Docs.pyruff check agents-api/agents_api/routers/docs/search_docs.py agents-api/tests/test_docs_routes.py agents-api/agents_api/autogen/Docs.pypyright agents-api(fails: Import "ward" could not be resolved)