Enable cors #4
Open
Enable cors #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheikalthaf
commented
Jan 13, 2019
| /** | ||
| * graphql routes | ||
| */ | ||
| $app->post('/graphql', GraphQLController::class .':process'); |
There was a problem hiding this comment.
Instead of string mentioning the actual class will help to navigate easily
juffalow
reviewed
Jan 13, 2019
| * Please change the `origin` header according to requirement | ||
| */ | ||
| $app->options('/{routes:.+}', function ($request, $response, $args) { | ||
| return $response; |
There was a problem hiding this comment.
If I try to access from angular application then I'm getting cors error
There was a problem hiding this comment.
Ok, now I see where is the problem :)
juffalow
reviewed
Jan 14, 2019
|
|
||
| $app->add(function ($req, $res, $next) { | ||
| $response = $next($req, $res); | ||
| return $response |
There was a problem hiding this comment.
Here is the problem. You should not return the response, but call the next callback and return it.
$response = $response->withHeader('Access-Control-Allow-Origin', '*')
->withHeader('Access-Control-Allow-Headers', 'X-Requested-With, Content-Type, Accept, Origin, Authorization')
->withHeader('Access-Control-Allow-Methods', 'GET, POST, PUT, DELETE, PATCH, OPTIONS');
return $next($request, $response);
If you will do it like this, you can remove $app->options('/{routes:.+}', function ...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORS options added