Remove process.versions.node for node detection #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some libraries do a Node.js detection like
if (process.versions.node). For this reason we shouldn't be polyfilling this version.@Mesteery I think at some point it could be worth considering splitting the Node.js libs into two classes by having two condition combinations -
"browser"or"browser" + "node", where"browser" + "node"effectively does something more like web containers in fully trying to virtualize Node.js in a browser as an environment condition. It would be interesting to see how far we could get with workflows around that. For process this would effectively split it into two -process-browser.jsandprocess-browser-node.js.