Skip to content

Use EISOP CF release again #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wmdietl merged 2 commits into from
Dec 26, 2024
Merged

Use EISOP CF release again #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00d89e3
Use EISOP CF release again
wmdietl Dec 22, 2024
aac5056
Fix other included build
wmdietl Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,12 @@ jobs:
with:
repository: jspecify/jspecify
path: jspecify
- name: Check out eisop/checker-framework
uses: actions/checkout@v4
with:
repository: eisop/checker-framework
path: checker-framework
# Clone the EISOP CF if necessary:
# - name: Check out eisop/checker-framework
# uses: actions/checkout@v4
# with:
# repository: eisop/checker-framework
# path: checker-framework
- name: Set up Java
uses: actions/setup-java@v4
with:
Expand All @@ -32,7 +33,9 @@ jobs:
- name: Set up Gradle
uses: gradle/gradle-build-action@v3
- name: Build and Test
run: ./gradlew build conformanceTests demoTest --include-build ../jspecify --include-build ../checker-framework
run: ./gradlew build conformanceTests demoTest --include-build ../jspecify
Copy link
Collaborator

@cpovirk cpovirk Dec 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI results suggest that we'll need a similar change for Run Samples Tests below.

Copy link
Collaborator Author

@wmdietl wmdietl Dec 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I had missed that.

# If a cloned EISOP CF is needed, use the following:
# run: ./gradlew build conformanceTests demoTest --include-build ../jspecify --include-build ../checker-framework
env:
SHALLOW: 1
JSPECIFY_CONFORMANCE_TEST_MODE: details
Expand All @@ -44,7 +47,9 @@ jobs:
working-directory: jspecify
- name: Run Samples Tests
if: always()
run: ./gradlew jspecifySamplesTest --include-build ../jspecify --include-build ../checker-framework
run: ./gradlew jspecifySamplesTest --include-build ../jspecify
# If a cloned EISOP CF is needed, use the following:
# run: ./gradlew jspecifySamplesTest --include-build ../jspecify --include-build ../checker-framework

publish-snapshot:
name: Publish Conformance Test Framework Snapshot
Expand Down
2 changes: 1 addition & 1 deletion settings.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ exec {
dependencyResolutionManagement {
versionCatalogs {
libs {
version("checkerFramework", "3.42.0-eisop4")
version("checkerFramework", "3.42.0-eisop5")

library("checkerFramework-checker", "io.github.eisop", "checker").versionRef("checkerFramework")
library("checkerFramework-checker-qual", "io.github.eisop", "checker-qual").versionRef("checkerFramework")
Expand Down
Loading