Skip to content

Conversation

@wmdietl
Copy link
Collaborator

@wmdietl wmdietl commented Aug 22, 2024

Depends on eisop/checker-framework#878
Also tests whether the EISOP CI picks up this corresponding branch in the reference checker.

@wmdietl wmdietl self-assigned this Aug 22, 2024
@wmdietl wmdietl marked this pull request as ready for review August 23, 2024 02:12
@wmdietl wmdietl assigned cpovirk and unassigned wmdietl Aug 23, 2024
@wmdietl
Copy link
Collaborator Author

wmdietl commented Aug 23, 2024

EISOP CI build correctly picks up this branch and is successful.
I'll merge the two PRs together once they're approved.

In an ideal world this PR would pick up the corresponding EISOP branch...

Copy link
Collaborator

@cpovirk cpovirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@wmdietl
Copy link
Collaborator Author

wmdietl commented Aug 23, 2024

In CI I notice this failure:

FAILURE: Build failed with an exception.

* What went wrong:
Circular dependency between the following tasks:
:jspecify:classes
\--- :jspecify:compileJava
     \--- :jspecify:jar
          +--- :jspecify:classes (*)
          +--- :jspecify:compileJava (*)
          +--- :jspecify:compileJava9Java
          |    \--- :jspecify:jar (*)
          \--- :jspecify:java9Classes
               \--- :jspecify:compileJava9Java (*)

(*) - details omitted (listed previously)

The same problem can be reproduced with main, meaning it doesn't depend on this PR and doesn't depend on changes in EISOP.

I can reproduce it with jspecify-reference-checker in the main branch using an --include-build ../jspecify configuration.
However, I didn't figure out how to trigger the circular dependency directly in the jspecify build.

When I go into jspecify and execute git checkout 0394cfed29ae86d75ad327dc9df9697e0b9b90a6, that is, if I use the state before jspecify/jspecify#605, the build of the reference checker succeeds.

So something about jspecify/jspecify#605 is breaking the build of the reference checker.

@cpovirk Any idea?

@wmdietl
Copy link
Collaborator Author

wmdietl commented Aug 23, 2024

I'll merge this PR to make main-eisop compile against the updated EISOP. I'll turn the previous comment into a new issue.

@wmdietl wmdietl merged commit eea8585 into main-eisop Aug 23, 2024
@wmdietl wmdietl deleted the contracts-tweaks branch August 23, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants