Skip to content

Conversation

@cpovirk
Copy link
Collaborator

@cpovirk cpovirk commented Jul 26, 2024

No description provided.

@cpovirk cpovirk requested a review from wmdietl July 26, 2024 14:55
@cpovirk cpovirk changed the base branch from main to main-eisop July 26, 2024 15:03
Copy link
Collaborator

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This depends on eisop/checker-framework#816, which isn't in a release yet.
So you get NullSpecChecker.java:72: error: method does not override or implement a method from a supertype.
You could change CI to again build a local clone of EISOP and use that.

Copy link
Collaborator

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#196 includes a local CF in CI so this compiles now.

@wmdietl wmdietl assigned cpovirk and unassigned wmdietl Jul 26, 2024
@cpovirk cpovirk merged commit 3c80e50 into main-eisop Jul 26, 2024
@wmdietl wmdietl deleted the asnullness branch July 26, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants