Stop recognizing annotations from the old package. #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
What about the others, here? |
Collaborator
Author
|
Oopsie. Thanks. Done. |
netdpb
reviewed
Jun 26, 2024
| "org.jetbrains.annotations.Nullable", | ||
| "org.jmlspecs.annotation.Nullable", | ||
| "org.jspecify.annotations.Nullable", | ||
| "org.jspecify.nullness.Nullable", |
Collaborator
There was a problem hiding this comment.
What's up with these entire lists? If this is the reference checker for JSpecify annotations, should it understand anything else at all?
Collaborator
Author
There was a problem hiding this comment.
Do you have in mind downsides to recognizing other annotations? The checker already goes beyond the JSpecify spec by handling things like dataflow, and of course we use it on some projects like Guava for our own purposes. I could imagine putting all that logic behind flags (so that the conformance tests could disable it), but I'm not sure what we'd get out of it.
netdpb
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.