-
Notifications
You must be signed in to change notification settings - Fork 292
Open
Description
Currently, basics.location.address
is a string, and it's documented that users should use \n
to insert line breaks.
I think it'd be better to allow users to define the address lines separately with a string[]
. (string
can still be permissible)
The change would be backward compatible, theme templates would just have to check if it's an array or a string literal.
{
"basics": {
"location": {
"address": "International House\n24 Holborn Viaduct\nLondon, EC1A 2BN"
}
}
}
{
"basics": {
"location": {
"address": [
"International House",
"24 Holborn Viaduct",
"London, EC1A 2BN"
]
}
}
}
The change in the schema would probably look like the following, and again, would be backward compatible.
{
"title": "Address",
"description": "Your physical address.",
"oneOf": [
{
"type": "array",
"description": "The address lines for your physical address.",
"items": {
"type": "string",
"description": "A single line from the physical address."
}
},
{
"type": "string",
"description": "To add multiple address lines, use \n. For example, 1234 Glücklichkeit Straße\nHinterhaus 5. Etage li."
}
]
}
Alternatively, we could also just deprecate the old way of doing it as well?
kiyui, europrimus, hankconn and nettnikl
Metadata
Metadata
Assignees
Labels
No labels