chore(error messages): clarify reasons for refusing values #237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working with this package via
@nestjs/platform-express
and I updated it from v0.5.0 to v0.7.1. After this my application login stopped working. I checked why this was, and ultimately I found out that thecookieNameRegExp
check was rejecting my cookie name. This cookie name was valid before:test::name
This wasn't valid anymore after updating. I don't know if this is correct, or if it is maybe already fixed in the most recent version of the package. That is not my issue.
What would have helped me find my issue sooner is a better error message. Looking at the existing text
argument name is invalid
makes it seem like the argument variable name itself is invalid. I would suggest improving the error texts like so:I have improved this in all error messages in the
index.ts
file.