fix: DOC503 catch namespaced exceptions #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, AST walking was not properly identifying the name of exceptions like `m.Exception`. Update logic for determining names from an AST to correctly get the whole name (as well as related tests).
Amar1729
force-pushed
the
165-fix/doc503-namespaced-exception
branch
from
e205043 to
b044ece
Compare
|
Updated with another edge case from #165 (comment) |
|
Thank you again @Amar1729 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, AST walking was not properly identifying the name of exceptions like
m.Exception. Update logic for determining names from an AST to correctly get the whole name (as well as related tests).Fixes #165
Seems to work as expected on the minimal case provided in that issue. Can you think of other edge cases I've missed adding to the tests?