Optimize mappingTable size #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraynel
force-pushed
the
decrease-package-size
branch
from
7de635b to
f5efc93
Compare
kraynel
force-pushed
the
decrease-package-size
branch
from
f5efc93 to
3a70a12
Compare
TimothyGu
reviewed
Feb 10, 2020
index.js
Outdated
|
|
||
| if (min <= val && max >= val) { | ||
| if (target[1] === STATUS_MAPPING.disallowed_STD3_valid || target[1] === STATUS_MAPPING.disallowed_STD3_mapped) { | ||
| let newStatus = ""; |
There was a problem hiding this comment.
This should probably not be initialized here, as the code block below initializes it to a number.
TimothyGu
reviewed
Feb 10, 2020
kraynel
commented
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package size is currently 317kb.
The generated
mappingTable.jsonalone is 253kb.In this PR I optimize this file to be around 130kb (51% the original size):
validcharcodes, drop last 2 columns (not used)I guess we could go a lot further. One way of drastically reducing the package size would be to build the mapping table during the
postInstallphase and not package them.