Skip to content

Conversation

st-matskevich
Copy link
Contributor

@st-matskevich st-matskevich commented Jul 15, 2025

I'm using dev-mapper to stitch partitions into one disk. Because dev-mapped devices appear under every source device, grep'ing produces multiple entries and breaks logic. This PR simply adds uniq to all lsblk calls to avoid such problems.

lsblk output

NAME         MAJ:MIN RM   SIZE RO TYPE MOUNTPOINTS
loop0          7:0    0  21.1G  1 loop
└─overlay    254:0    0    22G  0 dm
  ├─overlay1 254:1    0   255M  0 part /mnt/export-boot
  └─overlay2 254:2    0  21.1G  0 part /mnt/export-windows
loop1          7:1    0    22G  0 loop
└─overlay    254:0    0    22G  0 dm
  ├─overlay1 254:1    0   255M  0 part /mnt/export-boot
  └─overlay2 254:2    0  21.1G  0 part /mnt/export-windows

Result without uniq

Checking block devices for ESP (sudo required)...
Partition at /dev/mapper/overlay1 is vfat
vfat format.
ESP must be FAT or NTFS format.

Result with uniq

Checking block devices for ESP (sudo required)...
Copy the EFI boot files to the ESP...
Build the main BCD store...
Loader GUID: {ab1c6758-6c9a-47e3-bf03-836974eb7037}
Resume GUID: {e7b626e8-44d9-414d-9bb8-bfabe704c49f}
Build the recovery BCD store...
Copy the BCD hives to the ESP folders...
Copy bootmgfw.efi to default boot path...
Clean up temporary files...
Finished configuring UEFI boot files.

@st-matskevich
Copy link
Contributor Author

@jpz4085 what do you think about this one? Could you please review it?

@jpz4085 jpz4085 self-assigned this Jul 25, 2025
@jpz4085 jpz4085 merged commit de03424 into jpz4085:main Jul 25, 2025
@jpz4085
Copy link
Owner

jpz4085 commented Jul 25, 2025

Hi @st-matskevich this looks good to me. Sorry for the prolonged delay but I didn't have time to look at this until now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants