adding ?skipsvgo url option #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jpkleemans can you have a look into this PR? We really need this functionality |
jpkleemans
requested changes
Jun 15, 2022
Owner
jpkleemans
left a comment
jpkleemans
left a comment
There was a problem hiding this comment.
Hi Martin, I'm sorry for the delay. Thanks for your PR!
Could you review my comments?
Contributor
Author
|
hey @jpkleemans your are right - i changed the return types (typescript and docs) as suggested! Could you have a 2nd look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a few svg icons that need other options for the optimization. So a one fits all SVGO config dont fit here.
As a quick fix i added a option to skip svgo for a specific file