Add PHP7 to Travis with failures allowed #554
Conversation
|
|
||
| matrix: | ||
| allow_failures: | ||
| - php: 7.0 |
There was a problem hiding this comment.
I'd suggest adding Fast Finish support here, like this:
matrix:
allow_failures:
- php: 7.0
fast_finish: true
There was a problem hiding this comment.
Fast finish means exit on first error?
There was a problem hiding this comment.
With fast finishing enabled, Travis CI will mark your build as finished as soon as one of two conditions are met: The only remaining jobs are allowed to fail, or a job has already failed. In these cases, the status of the build can already be determined, so there's no need to wait around until the other jobs finish.
https://blog.travis-ci.com/2013-11-27-fast-finishing-builds/
There was a problem hiding this comment.
That makes a lot of sense. Commit to enable fast finish pushed :)
|
Cool, can you add 7.1 too? |
|
Definitely! Well, in the second attempt anyway 😇 (having a bit of a day.. ;) ) |
|
Thanks, would you like to rebase some of your commits or should I just let GitHub squash it? |
With failures allowed for 7.0 and 7.1 and fast finish enabled.
mheijkoop
force-pushed
the
travis-php7
branch
from
94b255f to
0f0db43
Compare
|
Done! :) |
|
Thanks! |
With failures allowed for 7.0 and 7.1 and fast finish enabled.
Please note this curently fails for master (see #553) and spits out a whole bunch of deprecation warnings.
There also seems to be an issue with the memcached module missing in the Travis PHP 7.0 environment, I'm not seeing that problem here locally as I've manually installed memcached.
I've set it to allow failures for PHP 7, so full PHP 7 compatibility can be monitored without ruining the happy green badges. Of course I'm hoping the
allow_failuressetting can be removed soon ;)