store cache on first fetch, expire on update #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koenpunt
force-pushed
the
reverse-cache-read-write
branch
from
8cb4de3 to
397f801
Compare
koenpunt
force-pushed
the
reverse-cache-read-write
branch
from
397f801 to
08c4927
Compare
koenpunt
force-pushed
the
reverse-cache-read-write
branch
from
b368a77 to
ff7974e
Compare
|
@jpfuentes2 @cvanschalkwijk can you review this? |
|
This makes sense to me. 👍 |
|
This fixes a bug which has been introduced on master during the debates for 1.1/1.2 releases, so I think it's probably best to merge this in master as is. |
|
I'm a fan, how about you @cvanschalkwijk ? |
Closed
|
Looks good. I would, I would like to start targeting pull requests into the releases so we can start including change logs. I would prefer to see this added to 1.1 or 1.2 instead of directly to master and we can start using the changelog again and get out of the habit of going straight into production. cc #470 |
AlexPerov
pushed a commit
to AlexPerov/php-activerecord
that referenced
this pull request
Nov 20, 2019
* store cache on first fetch, expire on update * update test to ensure cache update * make sure model->reload does not use cached values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store a cached version of the model on first fetch, instead of create/update. Expire cache on create, update or delete.
This prevents caching of
nullvalues for columns with (dynamic) defaults in the database.Todo: