Specify ca file from certifi #893
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelhenry
force-pushed
the
master
branch
2 times, most recently
from
acf100f to
5ef5acf
Compare
for more information, see https://pre-commit.ci
auvipy
requested changes
Jun 5, 2023
|
@auvipy thanks for the review. Is it okay if execute an actual request? because the |
|
I'm not sure I see the value of including an additional dependency here. I'd rather see #891 get in |
|
@jpadilla true, that one is more dynamic. I can close this pr and hopefully to merge it soon. Thanks |
|
Closing this pr with respect to #891 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #892