Skip to content

Validate claims if configured and verify_signature is not. #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 15, 2021
Merged

Validate claims if configured and verify_signature is not. #608

merged 3 commits into from
Feb 15, 2021

Conversation

@Natim
Copy link
Contributor

@Natim Natim commented Jan 22, 2021

Fixes #599

@Natim Natim mentioned this pull request Jan 22, 2021
Closed
glaucimar
glaucimar reviewed Jan 22, 2021
View reviewed changes
Copy link

@glaucimar glaucimar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely fixes my issue and my need too.

@Natim
Copy link
Contributor Author

Natim commented Jan 27, 2021

@jpadilla what do you think?

jpadilla
jpadilla approved these changes Feb 3, 2021
View reviewed changes
Copy link
Owner

@jpadilla jpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! Could you add to the changelog as well?

@Natim
Copy link
Contributor Author

Natim commented Feb 3, 2021 •
edited
Loading

I added a changelog entry, hope it's good enough.

@Natim
Copy link
Contributor Author

Natim commented Feb 11, 2021

@jpadilla I'm sorry to bug you about this, would you be able to make a release for this fix?

@jpadilla jpadilla merged commit 373d4d8 into jpadilla:master Feb 15, 2021
@Natim Natim deleted the bug/599/validate_claims_doesnt_requires_validate_signature branch April 1, 2021 18:37
@Natim
Copy link
Contributor Author

Natim commented Apr 1, 2021

@jpadilla I'm sorry to bug you about this, would you be able to make a release for this fix?

@Natim
Copy link
Contributor Author

Natim commented Apr 28, 2021

@jpadilla any idea of what I can do to help about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpadilla jpadilla jpadilla approved these changes

+1 more reviewer

@glaucimar glaucimar glaucimar left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

jwt.decode verify_signature=False and verify_exp=True doesn't work properly

3 participants

@Natim @jpadilla @glaucimar