Skip to content

Import collection ABC's from correct module #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2018
Merged

Import collection ABC's from correct module #384

merged 2 commits into from
Nov 25, 2018

Conversation

@thombashi
Copy link
Contributor

@thombashi thombashi commented Nov 25, 2018

The issue and the solution are the same with #375.

from collections import Mapping

The above line at jwt/api_jws.py would also be expected to import from collections.abc on Python 3.7 or later. This PR fix the import.
Move existing compatible imports in jwt/api_jwt.py to jst/compat.py and reuse it at jwt/api_jws.py.

jpadilla
jpadilla approved these changes Nov 25, 2018
View reviewed changes
Copy link
Owner

@jpadilla jpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks!

@jpadilla jpadilla merged commit 30d4c5a into jpadilla:master Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpadilla jpadilla jpadilla approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thombashi @jpadilla