Compose createDevStore with previous createStore #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
dmaskasky
commented
Jul 22, 2025
Comment on lines
165
to
180
| const prevStore = prevCreateStore?.(); | ||
| const buildingBlocks = ( | ||
| prevStore ? INTERNAL_getBuildingBlocksRev1(prevStore) : [] | ||
| ) as BuildingBlocks; | ||
| buildingBlocks[0] ??= new WeakMap(); | ||
| buildingBlocks[1] ??= new WeakMap(); | ||
| buildingBlocks[6] ??= {}; | ||
| const storeHooks = INTERNAL_initializeStoreHooks(buildingBlocks[6]); | ||
| const atomWrite = buildingBlocks[8]; | ||
| buildingBlocks[8] = (atom, get, set, ...args) => { | ||
| if (inRestoreAtom) { | ||
| return set(atom, ...args); | ||
| } | ||
| return atomWrite | ||
| ? atomWrite(atom, get, set, ...args) | ||
| : atom.write(get, set, ...args); | ||
| }; | ||
| const store = INTERNAL_buildStore(...buildingBlocks); | ||
| const [atomStateMap, mountedAtoms] = buildingBlocks; |
There was a problem hiding this comment.
@dai-shi
I think we need more thought around how to derive a store from a previous store. Currently, overriding certain building blocks won't work as expected.
dai-shi
reviewed
Jul 22, 2025
dmaskasky
force-pushed
the
dmaskasky-compose-with-prevstore
branch
2 times, most recently
from
26b1d10 to
5c27901
Compare
dmaskasky
force-pushed
the
dmaskasky-compose-with-prevstore
branch
from
5c27901 to
2c586d0
Compare
dai-shi
reviewed
Jul 23, 2025
| const prevStore = prevCreateStore?.() ?? INTERNAL_buildStore(); | ||
| const buildingBlocks = [ | ||
| ...INTERNAL_getBuildingBlocksRev1(prevStore), | ||
| ] as BuildingBlocks; |
There was a problem hiding this comment.
Isn't it already mutable without the type annotation?
There was a problem hiding this comment.
I think buildingBlocks should be frozen.
There was a problem hiding this comment.
Yes, it should be frozen. I'm only talking about the typing. Doesn't this work?
const buildingBlocks = [
...INTERNAL_getBuildingBlocksRev1(prevStore),
];
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If a previous createStore has already overridden createStore, we should try our best to compose with it.