-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Labels
enhancementNew features or code improvementsNew features or code improvementsgood first issueEasy to solve for newcomersEasy to solve for newcomers
Milestone
Description
💻 Feature request: replace assertions by custom exceptions
In most of the solvers, different assertions regarding the validity of the parameters, the convergence to a given accuracy and others are executed. Assertions should only be applied within the tests/
directory. Instead, we must create custom exceptions and raise those, for example: IterationsError
, AtolError
, RevolutionsError
, RtolError
, InputError
, TransferAngleError
.
📝 References
This talks by Mario Corchero titled "Exceptional Exceptions" will be super useful!
Metadata
Metadata
Assignees
Labels
enhancementNew features or code improvementsNew features or code improvementsgood first issueEasy to solve for newcomersEasy to solve for newcomers