Allow specifying relative times in seconds #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Time values in seconds were not recognized as relative times in the same way as minutes, hours, etc. This produced surprising results; '30s' was passed directly to dateutil, which interpreted it as meaning 30 seconds into the current day, so awslogs displayed 15 hours of log data rather than the expected 30 seconds of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time values in seconds were not recognized as relative times in the
same way as minutes, hours, etc. This produced surprising results;
'30s' was passed directly to dateutil, which interpreted it as meaning
30 seconds into the current day, so awslogs displayed 15 hours of log
data rather than the expected 30 seconds of it.