Fix watch (-w) #196
Open
Fix watch (-w) #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only lint is failing (fixed in #194). Should I look into adding a test for this? |
blueyed
added a commit
to blueyed/awslogs
that referenced
this pull request
May 28, 2018
All tests were passing with some `assert 0` to see which tests cover jorgebastida#196, which should not happen.
|
Rebased. |
|
See #142 (comment) for what seems to be needed here, too. |
|
Actually this handles startTime already, and should be fine I guess?! |
Delete `nextToken` from kwargs, otherwise this will cause the response
to be stale / the same always.
This should get improved probably to update `kwargs['startTime']`
probably, but it is not clear to me if we could use the `max` or `min`
from the received events here. Maybe with some offset being applied for
safety (`self.parse_datetime("5m ago")`)?
Eventually this should get refactored, but it seems better to just silence mccabe for now. It also uses the default max-complexity for the rest now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete
nextTokenfrom kwargs, otherwise this will cause the responseto be stale / the same always.
This should get improved probably to updatekwargs['startTime']probably, but it is not clear to me if we could use the
maxorminfrom the received events here. Maybe with some offset being applied for
safety (
self.parse_datetime("5m ago"))?Fixes #195.