Refactor RPM::File#files #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, file listing is computed from rpm tags DIRNAMES and BASENAMES instead of piping to cpio. This also fixes a security issue where a malicious rpm could provide a custom PAYLOADCOMPRESSOR tag which would allow arbitrary shell execution. The security issue was reported by Joern Schneeweisz. Context: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/97602
|
I ran the test suite before/after the RPM::File#files refactor and tests path in both old/new code. |
jordansissel
added a commit
that referenced
this pull request
Sep 17, 2022
dirnames tags. The prior method (in #14) assumed basenames and dirnames had a 1:1 relationship, but the fpm test suite found this to be an incorrect assumption. Best I can tell, the relationship is: * basenames has the filenames * dirindexes is a list of array index offsets for a given file into the dirnames tag. For example, it seems like the first entry in basenames has a directory path of dirnames[dirindexes[0]]
|
I don't found an example of POC for this CVE, so I build one using a Docker container with a test of exploit of the 0.0.11 💀 and the 0.0.12 🛡️: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now computes the list of packaged file paths using rpm tags instead of shelling out to
cpio -it