Error while taking screenshot after step in 3.0,0-rc-11

[amitkumar-qa]

@jonsamwell Getting error while taking screenshot after step execution, Could you please provide work around ASAP if possible because reports without screenshots doesnt make much sense?
Note:-in 3.0,0-rc-9 , It was working fine.

Sample code and error below:
AttachScreenshotStepHook.onAfterStep function:

Run after a step has executed
  @override
  Future<void> onAfterStep(
      World world, String step, StepResult stepResult) async {
    logger.i("onAfterStep '$step' ${stepResult.result}");
    try {
      final screenshotData = await takeScreenshot(world);
      world.attach(screenshotData, 'image/png', step);
    } catch (e, st) {
      world.attach('Failed to take screenshot\n$e\n$st', 'text/plain', step);
    }
    return super.onAfterStep(world, step, stepResult);
  }
}

Future<String> takeScreenshot(World world) async {
  final bytes = await (world as FlutterWorld).appDriver.screenshot();
  return base64Encode(bytes);
}

tter (15208): └─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── I/flutter (15208): - Then User clicks on create invoice button # :0 took 300ms I/flutter (15208): Attachment (text/plain): Failed to take screenshot I/flutter (15208): 'package:integration_test/_callback_io.dart': Failed assertion: line 73 pos 12: '!_isSurfaceRendered': Surface already converted to an image I/flutter (15208): #0 _AssertionError._doThrowNew (dart:core-patch/errors_patch.dart:51:61) I/flutter (15208): #1 _AssertionError._throwNew (dart:core-patch/errors_patch.dart:40:5) I/flutter (15208): #2 IOCallbackManager.convertFlutterSurfaceToImage (package:integration_test/_callback_io.dart:73:12) I/flutter (15208): #3 IntegrationTestWidgetsFlutterBinding.convertFlutterSurfaceToImage (package:integration_test/integration_test.dart:204:27) I/flutter (15208): #4 WidgetTesterAppDriverAdapter.screenshot (package:flutter_gherkin/src/flutter/adapters/widget_tester_app_driver_adapter.dart:72:21) I/flutter (15208): #5 takeScreenshot (file:///myrepo/integration_test/gherkin/hooks/screenshots_hooks.dart:72:57) I/flutter (15208): #6 AttachScreenshotStepHook.onAfterStep

[jonsamwell]

What devices are the tests running on?

…

On Fri, Jun 24, 2022, 5:58 PM amitkumar-qa ***@***.***> wrote: @jonsamwell <https://github.com/jonsamwell> Getting error while taking screenshot after hook, Could you please provide work around ASAP if possible because reports without screenshots doesnt make much sense. Note:-in 3.0,0-rc-9 , It was working fine. Sample code and error below: AttachScreenshotStepHook.onAfterStep function: ` /// Run after a step has executed @OverRide <https://github.com/OverRide> Future onAfterStep( World world, String step, StepResult stepResult) async { logger.i("onAfterStep '$step' ${stepResult.result}"); try { final screenshotData = await takeScreenshot(world); world.attach(screenshotData, 'image/png', step); } catch (e, st) { world.attach('Failed to take screenshot\n$e\n$st', 'text/plain', step); } return super.onAfterStep(world, step, stepResult); } } Future takeScreenshot(World world) async { final bytes = await (world as FlutterWorld).appDriver.screenshot(); return base64Encode(bytes); }` tter (15208): └─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── I/flutter (15208): - Then User clicks on create invoice button # :0 took 300ms I/flutter (15208): Attachment (text/plain): Failed to take screenshot I/flutter (15208): 'package:integration_test/_callback_io.dart': Failed assertion: line 73 pos 12: '!_isSurfaceRendered': Surface already converted to an image I/flutter (15208): #0 _AssertionError._doThrowNew (dart:core-patch/errors_patch.dart:51:61) I/flutter (15208): #1 _AssertionError._throwNew (dart:core-patch/errors_patch.dart:40:5) I/flutter (15208): #2 IOCallbackManager.convertFlutterSurfaceToImage (package:integration_test/_callback_io.dart:73:12) I/flutter (15208): #3 IntegrationTestWidgetsFlutterBinding.convertFlutterSurfaceToImage (package:integration_test/integration_test.dart:204:27) I/flutter (15208): #4 WidgetTesterAppDriverAdapter.screenshot (package:flutter_gherkin/src/flutter/adapters/widget_tester_app_driver_adapter.dart:72:21) I/flutter (15208): #5 takeScreenshot (file:///myrepo/integration_test/gherkin/hooks/screenshots_hooks.dart:72:57) I/flutter (15208): #6 AttachScreenshotStepHook.onAfterStep — Reply to this email directly, view it on GitHub <#235>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA4F7IOOXQFXAROPDME7N7DVQVTC3ANCNFSM5ZW4OYZQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[amitkumar-qa]

@jonsamwell Pixel 5 and pixel 2 on emulators, and pixel 6 on real device.

[jonsamwell]

@amitkumar-qa it seems that on Android this functionality is actually broken / not implemented in the flutter intergration_test library see flutter/flutter#92381.

So I am not really sure what I can do here at the moment as it seems you can only take one screenshot per test because of this issue.

[jonsamwell]

@amitkumar-qa I've replaced the old screenshot code for now so see if this works for you

[amitkumar-qa]

@jonsamwell Screenshots are appearing but complete screen is not visible in screenshots instead it is showing like zoomed image screen shot which only display left portion of the screen

Requesting your help to fix this.

[jonsamwell]

@amitkumar-qa I've tried for a bit but cannot fix this. It seems the layer that is being turned into an image (the parent layer) thinks it is smaller than the viewport size.

[amitkumar-qa]

@jonsamwell It was working fine 3.0,0-rc-9, Could you please revert the screenshot code as fix if possible ? Otherwise it will be difficult for our test report without screenshots.
Looking forward to hearing from you soon

[youssef-t]

@jonsamwell
The only thing to revert is this line:

flutter_gherkin/lib/src/flutter/adapters/widget_tester_app_driver_adapter.dart

Line 90 in b73da40

.toImage(renderObject.paintBounds)

Instead of using "paintBounds", it is possible to use "semanticBounds" to solve the issue.

My guess is that the coordinate system used by "paintBounds" is different than the one used by "semanticBounds".

[jonsamwell]

@youssef-t thanks for the pointer, that seems to work using the local coordinate system. The is release in version 3.0.0-rc.16

[amitkumar-qa]

@jonsamwell works like a charm in 3.0.0-rc.16
@youssef-t Really appreciate your suggestion.

Thanks guys

[vrnvorona]

How are screenshots on iOS for you? I get a MissingPluginException(No implementation found for method captureScreenshot on channel plugins.flutter.io/integration_test) error.

Using takeScreenshotUsingRenderElement works just fine, and a while ago it did always use render element for all screenshots.

Also maybe because of this open takeScreenshot method of AttachScreenshot hook? I used to simply override it, now I can't 😢