Skip to content

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Mar 10, 2025

No description provided.

@lyrixx lyrixx force-pushed the clean-tests branch 3 times, most recently from f819a9e to f8c403e Compare March 11, 2025 13:57
@joelwurtz joelwurtz requested review from Korbeil and nikophil March 11, 2025 14:39
@lyrixx
Copy link
Member Author

lyrixx commented Mar 24, 2025

I rebased this PR to fix the conflict.
It's ready BTW.

@lyrixx lyrixx requested a review from joelwurtz March 24, 2025 14:17
@joelwurtz
Copy link
Member

Could add an explanation (or even better a castor command) to generate or create the directory structure and file for a test with map and expected ?

I understand the logic behind but (with a light review) did not see how those files are created ? (I asumme there is no automation ATM ?)

@lyrixx
Copy link
Member Author

lyrixx commented Mar 24, 2025

Could add an explanation

Where ?

or even better a castor command

You want a command to generate one file?

I asumme there is no automation ATM ?

I did everything manually.

@joelwurtz
Copy link
Member

If it's not automatic, then only a README.md explaining (with a few lines) how this system work and how to create a test using this way since it's not a standard way to do it it may be nice for other contributors and can serve as a reference when reviewing

@lyrixx
Copy link
Member Author

lyrixx commented Mar 24, 2025

@joelwurtz joelwurtz merged commit d6a0c59 into main Mar 24, 2025
6 checks passed
@joelwurtz joelwurtz deleted the clean-tests branch March 24, 2025 16:09
@joelwurtz
Copy link
Member

Thanks 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants