Fix conditional check of options.sameOrigin

[eh-dub]

• typeof always returns a truthy value ([MDN link](mdn instanceof vs typeof))

PR Type

• Bugfix
• Feature
• Code style update (whitespace, formatting, missing semicolons, etc.)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other… Please describe:

Description

I changed the conditional check of options.sameOrigin in the constructor. The condition used to look at typeof options.sameOrigin which is always a truthy value (a string). Now it checks for the existence of the option directly.

The change is required to run this library in a nodejs environment because the window global variable does not exist.

How Has This Been Tested?

Before the code wouldn't run in a nodejs environment throwing the error window is undefined. Now the library works as advertised on nodejs environments.

Tested on Noder 14.9.0 on a Mac in an electron app.

Screenshots (if appropriate):

Does this PR introduce a breaking change?

• Yes
• No

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the contributing.md.

^ there is no contributing.md

[alx]

Hi @eh-dub

Thanks for the fix, new [email protected] version has been pushed to npm: https://www.npmjs.com/package/deepdetect-js

Have a nice day,

Alex