Fix non-constant format string errors with Go 1.24 #1745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `errors.New` instead of `fmt.Errorf` and `fmt.Fprint` instead of `fmt.Fprintf` if a non-constant string is used Signed-off-by: Michel Lind <[email protected]>
QuLogic
reviewed
Jan 27, 2025
Comment on lines
+82
to
85
| return nil, errors.New( | ||
| "at CST BuildMultipleArityFunctionCallsiteNode: function name not found: " + | ||
| builtinFunctionInfo.name, | ||
| ) |
There was a problem hiding this comment.
You could make this (and others) actually format instead of a concatenation:
Suggested change
| return nil, errors.New( | |
| "at CST BuildMultipleArityFunctionCallsiteNode: function name not found: " + | |
| builtinFunctionInfo.name, | |
| ) | |
| return nil, fmt.Errorf( | |
| "at CST BuildMultipleArityFunctionCallsiteNode: function name not found: %s", | |
| builtinFunctionInfo.name, | |
| ) |
|
|
||
| if ast.RootNode == nil { | ||
| return hadWarnings, fmt.Errorf("cannot build CST from nil AST root") | ||
| return hadWarnings, errors.New("cannot build CST from nil AST root") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
errors.Newinstead offmt.Errorfandfmt.Fprintinstead offmt.Fprintfif a non-constant string is usedgolang/go#60529