- 
                Notifications
    You must be signed in to change notification settings 
- Fork 227
Add bash completion #1684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add bash completion #1684
Conversation
| @johnkerl Are you ok with the approach for completion? Reading flags may require bit of refactor in command line parsing logic. | 
| @balki Hi and sorry for the delay! This is AWESOME stuff!!! 😎 Agreed re all four checkboxes -- if you're up for it, these are all great! It's better to have some completion than none at all, so, I'm happy to take these as separate PRs. I think  I'm happy to work with you on refactoring the command-line-parsing logic ... | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see requested change
Co-authored-by: John Kerl <[email protected]>
| Thank you! Will try to work on this in next few weeks. Yes bash is more popular and will start with bash as it is simpler. However zsh completion is more powerful and useful. E.g the flag completion has the help text which is very helpful. And mac os default shell is zsh. | 
| Has there been any progress on this? (Mostly, i'm asking to avoid duplicate work. If there hasn't been any work on zsh completion, i might have a look at it ...) | 
| 
 There has not :( 
 I would love that! :) | 
| Apologies. I am not working on this anymore for now. Anyone interested, please take over. | 
POC for bash completion support. It does two things as for now
then, it completes a verbDemo
Setup
Let me know if you like the approach. Can be enhanced further
cut -f..(extracted from first line of input in--fromflag)