Compiling on newer go versions doesn't work #1655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For whatever reason when compiling with go `1.23` it complains about needing to `go tidy` and running that bumps the go version to `1.21` and adds the `toolchain` directive, while also updating go.sum. Compiling on go `1.20` works just fine without this update. Not sure if you want to go all the way to `1.23` or do the minimum of `1.21` so I just picked the latter and can change if you want to.
|
@lespea let's keep 1.21. Personally I'd love to go newer but for some of the various distro builds newer Go versions aren't always available |
|
Hopefully this going from 1.19 -> 1.21 won't be too big of an issue. I don't know why it's complaining. I'm stuck w/1.20 @ work so I haven't used newer versions much. |
|
Thank you @lespea ! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatever reason when compiling with go
1.23it complains about needing togo tidyand running that bumps the go version to1.21and adds thetoolchaindirective, while also updating go.sum.Compiling on go
1.20works just fine without this update.Not sure if you want to go all the way to
1.23or do the minimum of1.21so I just picked the latter and can change if you want to.