Use targetPackage when javaType begins with a period character

[tcharman]

Using the maven plugin 0.3.6 I set targetPackage to com.foo and I declare in my json schema

        "myType": 
        {
            "description": "My Type",
            "type": "object",
            "javaType": "MyType",
            "additionalProperties": false,
            "properties": 
...

This generates a class called MyType that is in package com.foo (as I don't fully qualify the javaType). Now I upgraded to 0.4.2, and the type is generated with no package, only the top level package in the schema file is generated in the targetPackage package.

[joelittlejohn]

This is actually the expected behaviour but I think the behaviour you desire is preferable whenever the javaType value contains no . character. I think we should change this for the next version, as classes in the default package are useless (and in many cases harmful).

[joelittlejohn]

Need to make sure this works for both class and enum types.

[alexei-osipov]

Maybe it's better to have a contract: "if javaType starts with period then prepend it with targetPackage".

So:
"javaType": "MyType" → MyType.java
"javaType": ".MyType" → com.target.package.MyType.java
"javaType": ".some.sub.package.MyType" → com.target.package.some.sub.package.MyType.java

[joelittlejohn]

@alexei-osipov I like that suggestion :) It's quite powerful, although it does mean that people will likely have to use the docs to find this out (it's not obvious) and I wonder if it is ever useful to generate classes into the default (empty) package.

I like how a partial/sub-package can be specified like this too. Yeah, I like this suggestion.

[imdreamrunner]

Dear @joelittlejohn , may I know what's the progress for this issue? Any plan to change or create the sub-package? Many thanks!

[arnehaber]

I generally like the idea. However, I am generating classes for an official specification which contains JSON schema files and I do not want the change these. I suggest instead of using a period at start of a javaType to prepend the targetPackage, another configuration variable shalle be added such as useTargetPackageForUnqualifiedJavaTypes. If this is true, definitions with an unqualified javaType will be qualified with the configured targetPackage.