Dev/main to Main #75
Merged
Dev/main to Main #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sudo for vscode user
Some were running over this, which they shouldn't
chore: Updates workflow names for consistency in Github UI.
There was a problem hiding this comment.
Copilot reviewed 51 out of 55 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- .devcontainer/Dockerfile: Language not supported
- .devcontainer/devcontainer.json: Language not supported
- .github/workflows/jm-sync-with-upstream.yml: Language not supported
- api/package.json: Language not supported
.github/workflows/jm-build-only.yml
Outdated
| ref: ${{ github.event.inputs.branch || 'main' }} | ||
| # For manual runs: Use ref if provided, otherwise use branch | ||
| # For automated runs: Use the triggering ref | ||
| ref: ${{ github.event_name == 'workflow_dispatch' && (github.event.inputs.ref || github.event.inputs.branch) || github.ref }} |
There was a problem hiding this comment.
The conditional expression for selecting the git ref may be ambiguous; consider adding explicit parentheses to ensure the intended evaluation order.
Suggested change
| ref: ${{ github.event_name == 'workflow_dispatch' && (github.event.inputs.ref || github.event.inputs.branch) || github.ref }} | |
| ref: ${{ (github.event_name == 'workflow_dispatch' && (github.event.inputs.ref || github.event.inputs.branch)) || github.ref }} |
Copilot uses AI. Check for mistakes.
|
The promote-admin script needs to be tested with npm running in docker before we finish the merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames workflows for consistency and clarity in Github UI
Adds promote-admin script to npm scripts
Adds
-foption to promot-admin script.