Update From Chafey #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added support for creating subbuffers in the original type of buffer (Uint8Array or Buffer) - should help performance in node.js * removed bug introduced in 1.3 which incorrectly assumed that a basic offset table always existed in encapsulated frames
* updated readEncapsulatedPixelData to not use readSequenceItem() for finding delimeter item so the malfromed sequence check didn't cause it to fail * made error message for non DICOM P10 files more clear * improved clarity of some error messages by adding the source function to the message
…sult * changed dicomParser.from() to use use slice() instead of Buffer.from() * renamed dicomParser.from() to dicomParser.sharedCopy() * moved dicomParser.sharedCopy() into its own js file * enhanced DICOM Dump with Data Dictionary * can now dump details about the fragments * added sha1 calculation for entire DICOM P10 file, large binary elements and individual fragments
…yteOffset of the Uint8Array * Cleaned up node.js example * Updated rusha to newer version since the one in bower was old and had a bug with Uint8Arrays that had offsets on the underlying ArrayBuffer * DICOM Dump with Data Dictionary example now displays the transfer syntax and sop class
…g in node * added exception handling to node.js example
…ic offset table for the case where each image frame is encoded in exactly one fragment.
…capsulated data with no basic offset table
…multi-frame instances where no basic offset table existed * Added readEncapsulatedPixelDataFromFragments() to support sop instances with empty basic offset table * Added readEncapsulatedImageFrame to support sop instances with non zero basic offset tables
added test images
…parameter was ignored * enhanced DICOM Dump with Data Dictionary example * allows downloading of encapsulated image frames and binary data * allows downloading of raw binary data * added checkbox for showing and calculating SHA1 * the parsed dataSet is now in global scope to aid in debugging from the browser console * the parsed dataSet is now dumped to console to aid in debugging form the browser console
…ges and not really needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.