Skip to content

Update main-sc.json #16423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update main-sc.json #16423

wants to merge 2 commits into from

Conversation

jmontane
Copy link
Contributor

No description provided.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@damencho
Copy link
Member

Please fix the lint errors. Thank you.

@jmontane
Copy link
Contributor Author

Please fix the lint errors. Thank you.

I'm sorry, but I don't have enough programmer skills to understand what issues happen here. Please, can you point me what is wrong? Thanks in advance.

@damencho
Copy link
Member

Did you follow the README for the translations? There are some scripts that help on the way. The problem is that the language file keys are not alphabetically sorted in your PR.

@jmontane
Copy link
Contributor Author

Thanks! I've run update-translations.js script now. I hope it fixes the issues. Thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmontane @jitsi-jenkins @damencho @adrmzz