Skip to content

Conversation

mihhu
Copy link
Member

@mihhu mihhu commented Sep 4, 2025

No description provided.

@mihhu mihhu requested a review from Copilot September 4, 2025 11:49
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request integrates login functionality directly into the lobby screen and introduces new configuration options to control authentication UI elements. The main goal is to provide a more streamlined authentication experience by allowing users to log in from the lobby screen rather than through separate dialogs.

Key changes include:

  • Replaced the separate "Wait for Owner" dialog with integrated login buttons in lobby screens
  • Added new lobby configuration options (showLogIn, showHangUp) to control authentication UI visibility
  • Refactored authentication state management to use flags instead of dialog-based approach

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
react/features/lobby/components/web/LobbyScreen.tsx Added login button and hangup functionality to web lobby screen
react/features/lobby/components/native/LobbyScreen.tsx Added login button and hangup functionality to native lobby screen
react/features/prejoin/components/native/Prejoin.tsx Added conditional hangup button to prejoin screen
react/features/authentication/reducer.ts Updated state management to use moderator login flags instead of dialog timeouts
react/features/authentication/middleware.ts Refactored to enable/disable moderator login instead of opening dialogs
react/features/base/config/configType.ts Added new lobby configuration options for login and hangup buttons
react/features/base/config/reducer.ts Added migration logic for deprecated hideLoginButton config

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mihhu mihhu force-pushed the lobby-login branch 4 times, most recently from fd13e27 to a4b9c17 Compare September 5, 2025 08:15
@Calinteodor Calinteodor force-pushed the lobby-login branch 3 times, most recently from c9e23b3 to 0e5d860 Compare September 8, 2025 08:39
@damencho damencho force-pushed the lobby-login branch 2 times, most recently from 20fa36b to 5fd03bd Compare September 10, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants