-
Notifications
You must be signed in to change notification settings - Fork 7.4k
feat(lobby) integrate login in lobby + configs #16401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request integrates login functionality directly into the lobby screen and introduces new configuration options to control authentication UI elements. The main goal is to provide a more streamlined authentication experience by allowing users to log in from the lobby screen rather than through separate dialogs.
Key changes include:
- Replaced the separate "Wait for Owner" dialog with integrated login buttons in lobby screens
- Added new lobby configuration options (
showLogIn
,showHangUp
) to control authentication UI visibility - Refactored authentication state management to use flags instead of dialog-based approach
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
react/features/lobby/components/web/LobbyScreen.tsx | Added login button and hangup functionality to web lobby screen |
react/features/lobby/components/native/LobbyScreen.tsx | Added login button and hangup functionality to native lobby screen |
react/features/prejoin/components/native/Prejoin.tsx | Added conditional hangup button to prejoin screen |
react/features/authentication/reducer.ts | Updated state management to use moderator login flags instead of dialog timeouts |
react/features/authentication/middleware.ts | Refactored to enable/disable moderator login instead of opening dialogs |
react/features/base/config/configType.ts | Added new lobby configuration options for login and hangup buttons |
react/features/base/config/reducer.ts | Added migration logic for deprecated hideLoginButton config |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fd13e27
to
a4b9c17
Compare
c9e23b3
to
0e5d860
Compare
20fa36b
to
5fd03bd
Compare
No description provided.