Skip to content

fix(chat): disableReactionsInChat feature flag not working #16324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(chat): disableReactionsInChat feature flag not working #16324

wants to merge 1 commit into from

Conversation

Zaid0412
Copy link
Contributor

Summary

This PR fixes the disableReactionsInChat feature by ensuring it is properly enforced in the chat UI. Additionally, it removes outdated or conflicting logic from a different file that was no longer functioning or necessary.

Changes

  • Added a new check for disableReactionsInChat in the appropriate location.
  • Removed old logic that was ineffective or duplicated.
  • Ensured consistent behavior when the feature flag is toggled.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zaid0412 @jitsi-jenkins