Add and use $navbar-breakpoint variable; Fixes #1042 #2109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem of a hard-coded breakpoint for when the hamburger menu becomes a full menu.
This is an improvement; it gives Bulma users needed flexibility without requiring hacking, workarounds like redefining breakpoints that may have unwanted side effects, or code duplication.
Proposed solution
Replace hard-coded desktop/touch mixins with from/until mixins that take a new $navbar-breakpoint variable.
Fixes #1042
Now people bringing in Bulma with Sass or SCSS can do something like the following; in their main .scss file in this example:
Tradeoffs
None; it continues to work identically as before if no-one sets this variable.
Testing Done
I replaced Bulma in node_modules with a clone of my forked repository that has only this change, and it worked exactly as intended. Bulma provided all the tools to make this an easy modification; now everyone can have access to it.
Thanks!