-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
add support for reading typst pagebreak #11126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even with a good test :) Thanks!
I'm leaving this for @jgm to merge, as this will set the precedence on how pagebreaks are represented in the AST.
|
If we are using a div here, we might consider adding @tarleb does that make sense? For the class name, should it be Or should we go whole hog and add PageBreak to the AST? |
|
Ah right, I had forgotten about our |
I'll probably have about a week of quiet time soon, in which I should be able to work on some of those bigger changes. I guess we'd want to bundle a couple of AST changes into a single release? |
|
Right, I guess in German you are used to jamming words together! I'm not sure about the AST change. I don't like to rely on string typing, though. So if there are a significant number of formats that would support page breaks, and we're willing to put in the work to support them in readers and writers, it might be worth considering. AST changes are disruptive, though. |
|
It seems that you both are still considering a different approach of adding this to the AST more broadly. I'm not sure if that means you want to merge this PR in the mean time or just wait. In any case, I renamed pagebreak to page-break and added wrapper=1 so I think your suggestions are addressed if you do want to merge this. @tarleb PS: If you want to squash and merge that's fine. Or I can do that locally and push it up if necessary. |
|
Excellent, thanks! I think the plan is to merge this, we're just thinking out loud about possible alternatives and future changes. |
Closes #11101