-
Notifications
You must be signed in to change notification settings - Fork 46
Update usage in README to use rbenv-gemset command #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I like this writeup, but I have a few problems with this:
|
To clarify my understanding about the content of the
Also I was wondering if it would be nicer to demonstrate the usage instead of the write up. What do you think about changing it to: cd my-project
# Setup gemset for your project. Also will create a .rbenv-gemset file in the current directory.
# Please note this will create gemset under the $RUBY_VERSION.
rbenv-gemset init
# To create a gemset under a specific ruby version you can use the following command:
rbenv-gemset create [version] [gemset]
# You can see the existing gemset by using the following command:
# This should include the most recent gemset you just created.
rbenv-gemset list
# You can delete the gemset with the following command:
rbenv-gemset delete [version] [gemset] I will add the notes about content of And yes I meant the issue #27 not the pull request. |
2c55dd6
to
5e05066
Compare
Overall, your doc is good for a newbie, but as a note, me being me, I'd like to have a "supergeek" version as well (I'll take care of that, don't worry; this is just a reminder to self). Some specific notes:
Lastly, are you able to update your patch with reference to the latest code? Thanks! |
I have updated the usage section with the demonstration example, and I included the those two major points. In my case both Let me know if there is anything else you want me to change or add. Cheers! |
hi @ardeshirj , sorry about the long wait. I'm just going through the modified README now. I do see some things that need to be changed... but I think to make it easier for you, what I'll do is pull this into a separate branch, edit it there, and then merge the final result back. I trust this is ok with you? I'll do this in a couple of days unless you have a problem. |
I'm struggling a bit with the following 2 blocks of text, btw: By default the rbenv-gemset init command will create the primary gemset, which is the project name, and it will initialize the directory under the $(rbenv prefix "$RBENV_VERSION")/gemsets/$RBENV_GEMSET. If you are using the bundler it should install the gems and the dependencies in above path. You can modify the content of .rbenv-gemsets so the gems will be installed in the project directory (for example .gems or ./gems) These are my thoughts so far. On the one hand, I appreciate the information. On the other, I don't know if this may be a bit too much for this section (I'm considering this section the "superfantastic somebody-should-have-written-this-down-a-long-time-ago bare minimum all-you-need-to-know section"). Also:
All in, though, great writeup, and I appreciate you working with me on this. Thanks for stepping in to do this! |
Update usage to use the
rbenv-gemset
command instead of creating files manually. PR #27