[VC-43753] CyberArk(client): add CyberArk snapshot conversion

[wallrj-cyberark]

Add CyberArk snapshot conversion

• Introduced convertDataReadings to process DataReading objects into snapshots.
• Added support for extracting Kubernetes server version and dynamic resources.
• Updated CyberArkClient to use the new data conversion logic.
• Refactored DiscoveryData and DynamicData structures for better type safety.
• Replaced unstructured.Unstructured with runtime.Object in Snapshot fields.
• Enhanced DataGathererDiscovery and DataGathererDynamic to return strongly typed data.
• Added unit tests for new data extraction and conversion functions.

Part of: https://venafi.atlassian.net/browse/VC-43753

Followup PRs

1. [VC-43753] CyberArk(client): extract cluster UID from data readings #687
2. [VC-43403] CyberArk(helm): add Disco Agent Helm chart #678

Testing

 go run . agent --one-shot --machine-hub --agent-config-file ./examples/machinehub.yaml
I0901 08:10:33.203046 1119769 run.go:58] "Starting" logger="Run" version="development" commit=""
I0901 08:10:33.205033 1119769 run.go:116] "Healthz endpoints enabled" logger="Run.APIServer" addr=":8081" path="/healthz"
I0901 08:10:33.205147 1119769 run.go:120] "Readyz endpoints enabled" logger="Run.APIServer" addr=":8081" path="/readyz"
I0901 08:10:33.205193 1119769 run.go:269] "Pod event recorder disabled" logger="Run" reason="The agent does not appear to be running in a Kubernetes cluster." detail="When running in a Kubernetes cluster the following environment variables must be set: POD_NAME, POD_NODE, POD_UID, POD_NAMESPACE"
I0901 08:10:35.055576 1119769 identity.go:419] "successfully completed AdvanceAuthentication request to CyberArk Identity; login complete" logger="Run.gatherAndOutputData.postData" username="<REDACTED>"
I0901 08:10:36.875315 1119769 run.go:417] "Data sent successfully" logger="Run.gatherAndOutputData.postData"
richard@localhost:~/projects/jetstack/jetstack-secure$

$ tail -n1  request.txt | jq 
{
  "agent_version": "development",
  "cluster_id": "success-cluster-id",
  "k8s_version": "v1.33.1",
  "secrets": [
    {
      "apiVersion": "v1",
      "kind": "Secret",
      "metadata": {
        "creationTimestamp": "2025-08-29T04:07:15Z",
        "labels": {
          "cert-manager.io/next-private-key": "true",
          "controller.cert-manager.io/fao": "true"
        },
        "name": "samplewebhook-example-webhook-ca-zx9qh",
        "namespace": "samplewebhook",
        "ownerReferences": [
          {

[Copilot]

Pull Request Overview

This PR adds CyberArk snapshot conversion functionality to process DataReading objects into the snapshot format expected by the CyberArk API.

• Introduced data conversion logic with convertDataReadings and extractor functions for processing different resource types
• Updated type definitions to use runtime.Object instead of unstructured.Unstructured for better type safety
• Enhanced data gatherers to return strongly typed data structures (DynamicData and DiscoveryData)

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
pkg/client/client_cyberark.go	Added conversion logic and extractor functions for transforming DataReadings to CyberArk snapshots
pkg/client/client_cyberark_convertdatareadings_test.go	Added comprehensive test coverage for data conversion functions
pkg/client/client_cyberark_test.go	Added helper function for generating test data and updated test cases
pkg/internal/cyberark/dataupload/dataupload.go	Changed Snapshot field types from unstructured.Unstructured to runtime.Object
pkg/internal/cyberark/dataupload/dataupload_test.go	Updated test to use version constant instead of hardcoded value
pkg/internal/cyberark/dataupload/mock.go	Added assertions for cluster ID and agent version validation
pkg/datagatherer/k8s/discovery.go	Refactored to return strongly typed DiscoveryData instead of generic map
pkg/datagatherer/k8s/dynamic.go	Refactored to return strongly typed DynamicData instead of generic map
pkg/datagatherer/k8s/dynamic_test.go	Updated tests to work with new strongly typed return values
api/datareading.go	Added DynamicData and DiscoveryData type definitions
examples/machinehub.yaml	Updated configuration to include comprehensive resource gathering definitions

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

[nitpick] The generic type parameter T any is too permissive. Consider constraining it to *dataupload.Snapshot or create an interface that defines the expected behavior, as this function appears to be specifically designed for snapshot conversion.

Suggested change

	func convertDataReadings[T any](
	extractorFunctions map[string]func(*api.DataReading, *T) error,
	readings []*api.DataReading,
	target *T,
	func convertDataReadings(
	extractorFunctions map[string]func(*api.DataReading, *dataupload.Snapshot) error,
	readings []*api.DataReading,
	target *dataupload.Snapshot,

[Copilot]

The hardcoded cluster ID 'success-cluster-id' should be replaced with a more appropriate default or configuration-based value for production use. Consider using a UUID or extracting it from cluster metadata.