Put JSX closing brackets in new line in snapshots #2832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work! Thanks for sending a PR to Jest to help make testing better for everyone :) |
skovhus
pushed a commit
to skovhus/jest
that referenced
this pull request
Apr 29, 2017
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves clarity of snapshot diffs by placing closing brackets below the last prop in element.
Note: In case of element without props, closing bracket remains in the same line as opening tag - the same way as default
tag-alignedlocation in ESLint (react/jsx-closing-bracket-location) - recommended in Airbnb React/JSX Style guide, so it will print:instead of:
I have no strong opinion whether it should remain in the same line or go to next line in the same way as with multiline elements, so please let me know if I should change that.
Fixes #2830.