Skip to content

#15759 Fix it.concurrent not working with describe.skip #15765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eyalroth
Copy link
Contributor

@eyalroth eyalroth commented Aug 2, 2025

Fixes #15759.

Bug introduced in #15381.

Also attempts to fix flaky concurrency tests in e2e/__tests__/circusConcurrent.test.ts (example) by applying a factor on the delays in the tests. The differences between the delays were not long enough to ensure that they will keep a consistent ordering of the tests execution.

Copy link

netlify bot commented Aug 2, 2025

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2431cca
🔍 Latest deploy log https://app.netlify.com/projects/jestjs/deploys/688e29ec3b693b0008540260
😎 Deploy Preview https://deploy-preview-15765--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

pkg-pr-new bot commented Aug 2, 2025

Open in StackBlitz

babel-jest

npm i https://pkg.pr.new/babel-jest@15765

babel-plugin-jest-hoist

npm i https://pkg.pr.new/babel-plugin-jest-hoist@15765

babel-preset-jest

npm i https://pkg.pr.new/babel-preset-jest@15765

create-jest

npm i https://pkg.pr.new/create-jest@15765

@jest/diff-sequences

npm i https://pkg.pr.new/@jest/diff-sequences@15765

expect

npm i https://pkg.pr.new/expect@15765

@jest/expect-utils

npm i https://pkg.pr.new/@jest/expect-utils@15765

jest

npm i https://pkg.pr.new/jest@15765

jest-changed-files

npm i https://pkg.pr.new/jest-changed-files@15765

jest-circus

npm i https://pkg.pr.new/jest-circus@15765

jest-cli

npm i https://pkg.pr.new/jest-cli@15765

jest-config

npm i https://pkg.pr.new/jest-config@15765

@jest/console

npm i https://pkg.pr.new/@jest/console@15765

@jest/core

npm i https://pkg.pr.new/@jest/core@15765

@jest/create-cache-key-function

npm i https://pkg.pr.new/@jest/create-cache-key-function@15765

jest-diff

npm i https://pkg.pr.new/jest-diff@15765

jest-docblock

npm i https://pkg.pr.new/jest-docblock@15765

jest-each

npm i https://pkg.pr.new/jest-each@15765

@jest/environment

npm i https://pkg.pr.new/@jest/environment@15765

jest-environment-jsdom

npm i https://pkg.pr.new/jest-environment-jsdom@15765

@jest/environment-jsdom-abstract

npm i https://pkg.pr.new/@jest/environment-jsdom-abstract@15765

jest-environment-node

npm i https://pkg.pr.new/jest-environment-node@15765

@jest/expect

npm i https://pkg.pr.new/@jest/expect@15765

@jest/fake-timers

npm i https://pkg.pr.new/@jest/fake-timers@15765

@jest/get-type

npm i https://pkg.pr.new/@jest/get-type@15765

@jest/globals

npm i https://pkg.pr.new/@jest/globals@15765

jest-haste-map

npm i https://pkg.pr.new/jest-haste-map@15765

jest-jasmine2

npm i https://pkg.pr.new/jest-jasmine2@15765

jest-leak-detector

npm i https://pkg.pr.new/jest-leak-detector@15765

jest-matcher-utils

npm i https://pkg.pr.new/jest-matcher-utils@15765

jest-message-util

npm i https://pkg.pr.new/jest-message-util@15765

jest-mock

npm i https://pkg.pr.new/jest-mock@15765

@jest/pattern

npm i https://pkg.pr.new/@jest/pattern@15765

jest-phabricator

npm i https://pkg.pr.new/jest-phabricator@15765

jest-regex-util

npm i https://pkg.pr.new/jest-regex-util@15765

@jest/reporters

npm i https://pkg.pr.new/@jest/reporters@15765

jest-resolve

npm i https://pkg.pr.new/jest-resolve@15765

jest-resolve-dependencies

npm i https://pkg.pr.new/jest-resolve-dependencies@15765

jest-runner

npm i https://pkg.pr.new/jest-runner@15765

jest-runtime

npm i https://pkg.pr.new/jest-runtime@15765

@jest/schemas

npm i https://pkg.pr.new/@jest/schemas@15765

jest-snapshot

npm i https://pkg.pr.new/jest-snapshot@15765

@jest/snapshot-utils

npm i https://pkg.pr.new/@jest/snapshot-utils@15765

@jest/source-map

npm i https://pkg.pr.new/@jest/source-map@15765

@jest/test-result

npm i https://pkg.pr.new/@jest/test-result@15765

@jest/test-sequencer

npm i https://pkg.pr.new/@jest/test-sequencer@15765

@jest/transform

npm i https://pkg.pr.new/@jest/transform@15765

@jest/types

npm i https://pkg.pr.new/@jest/types@15765

jest-util

npm i https://pkg.pr.new/jest-util@15765

jest-validate

npm i https://pkg.pr.new/jest-validate@15765

jest-watcher

npm i https://pkg.pr.new/jest-watcher@15765

jest-worker

npm i https://pkg.pr.new/jest-worker@15765

pretty-format

npm i https://pkg.pr.new/pretty-format@15765

commit: 2431cca

@eyalroth eyalroth force-pushed the 15759-describe-skip-concurrent branch from f253935 to 7455f1e Compare August 2, 2025 14:46
@eyalroth eyalroth force-pushed the 15759-describe-skip-concurrent branch from 7455f1e to 2431cca Compare August 2, 2025 15:08
@eyalroth eyalroth marked this pull request as ready for review August 2, 2025 15:18
@eyalroth
Copy link
Contributor Author

eyalroth commented Aug 2, 2025

@madcapnmckay do you mind reviewing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: TypeError: Cannot read properties of undefined (reading 'then')
1 participant