toThrow(constructor, message)

[mattphillips]

Clone of jestjs/jest#3659

expect(()=>{
  throw new Error('1234');
}).toThrow(Error, 'hello');

All that needs working out is the name as toThrow is built into core and so this shouldn't clash with it

[natealcedo]

Hey! I'd love to take a crack at this. I was thinking something along the lines of toThrowWithMessage?

[benjaminkay93]

I like the idea of toThrowWithMessage

[mattphillips]

@natealcedo yup sounds good to me 👍

[natealcedo]

So I've actually started taking a look at how to implement this. I thought it would be a good idea to copy what jest's default toThrow matcher currently does. On that note I have a couple of questions.

1. Should we be doing something like this toThrowWithError(error, message) where message can either be a regex or a string as per what jest's toThrow does?
2. How strict do we want to be with argument validation. Should we raise an error when message has not been provided?

Just some of the thoughts I've been considering. I'll try to get in an initial pull request sometime next week so that you guys can verify what I've worked on and whether I'm going in the right direction.

[mattphillips]

@natealcedo I like the idea keeping this close to Jest’s current API with regex support.

As for the validation we should probably fail the matcher with a nice error message, saying the argument is missing.

At some point in the future I’m planning on adding validation throughout all of the matchers so don’t overthink it for now, perhaps just checking the message is supplied 😄

[natealcedo]

Let’s close since #170 fixes this :)

[mattphillips]

Released as part of v0.11.0 🎉