feat: Add basic Category Support for qBittorrent #902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Inochi Amaoto <[email protected]>
Signed-off-by: Inochi Amaoto <[email protected]>
Signed-off-by: Inochi Amaoto <[email protected]>
inochisa
force-pushed
the
qbittorrent-categories
branch
from
872e960 to
9aebf88
Compare
|
I'll merge this PR with squash, please do not force-push |
Sorry, I will do not do this again. Thanks for your reminder. |
trim21
reviewed
Aug 15, 2025
| @@ -19,6 +19,7 @@ export enum TorrentPriority { | |||
| export interface TorrentProperties { | |||
| bytesDone: number; | |||
| comment: string; | |||
| category: string; | |||
There was a problem hiding this comment.
are we sure this is not nullable or defined?
There was a problem hiding this comment.
I think it can be nullable, as '' can be used to identify no category.
trim21
reviewed
Aug 15, 2025
| @@ -88,6 +88,14 @@ export const getContextMenuItems = (torrent: TorrentProperties): Array<ContextMe | |||
| { | |||
| type: 'separator', | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
I'm not very familiar with our frontend code, is it possible to only show this with qBittorrent?
There was a problem hiding this comment.
Me too, I think it is necessary for showing with qBittorrent only.(Although I have found the category is not shown if every torrent does not have category)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce basic category support for qBittorrent.
These PR still have some gaps:
Related Issue
#686
Screenshots
Types of changes