Skip to content

Conversation

yujqiao
Copy link
Contributor

@yujqiao yujqiao commented Jun 1, 2025

Description

Log failed reason to help debug the connection

Related Issue

Screenshots

Types of changes

  • Breaking change (changes that break backward compatibility of public API or CLI - semver MAJOR)
  • New feature (non-breaking change which adds functionality - semver MINOR)
  • Bug fix (non-breaking change which fixes an issue - semver PATCH)

@trim21
Copy link
Collaborator

trim21 commented Jun 8, 2025

sorry for the delay, LGTM.

Copy link

codecov bot commented Jun 8, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.07%. Comparing base (b32abb6) to head (4c02201).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...erver/services/qBittorrent/clientRequestManager.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #882   +/-   ##
=======================================
  Coverage   73.06%   73.07%           
=======================================
  Files          66       66           
  Lines       11533    11533           
  Branches      985      988    +3     
=======================================
+ Hits         8427     8428    +1     
+ Misses       3090     3089    -1     
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trim21 trim21 enabled auto-merge (squash) June 8, 2025 15:26
@trim21 trim21 disabled auto-merge June 8, 2025 15:27
@trim21 trim21 enabled auto-merge (squash) June 8, 2025 15:27
@trim21 trim21 disabled auto-merge June 8, 2025 15:29
@trim21 trim21 enabled auto-merge (squash) June 8, 2025 15:30
@trim21
Copy link
Collaborator

trim21 commented Jun 8, 2025

I have trouble merging it....

@trim21
Copy link
Collaborator

trim21 commented Jun 8, 2025

can you try rebase on current trunk?

@trim21 trim21 disabled auto-merge June 8, 2025 16:14
@trim21
Copy link
Collaborator

trim21 commented Jun 8, 2025

I think github didn't auto merge this PR because it's behind the master branch.

Normally I would merge master back to this branch but looks like you didn't allow maintainers to update this PR, so you will have to do it on your own

@trim21 trim21 enabled auto-merge (squash) June 9, 2025 01:16
@trim21 trim21 merged commit 3ba8911 into jesec:master Jun 9, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants