Ensure that exec_chat also uses the overriden value. #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vagmi Thank you for this fix and clean commit. |
|
@vagmi FYI, I just released 0.4.0 with all of the new features: PDF, Images, custom headers, namespace (fireworks::gpt-oss-20b), a more streamlined MessageContent, and many fixes. Thanks a lot for your contribution to this release. Feel free to ping me if you have any issues or suggestions for the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a small bug where the exec_chat did not respect the overridden value. So exec_chat fails when using local models or Vertex AI.