-
Notifications
You must be signed in to change notification settings - Fork 121
feat: remain original response body #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remain original response body #68
Conversation
@4t145 So, this is a good advanced feature to have. Now, for the implementation, we would need a few things.
So, we have two options. a) Close this PR and create a new one with just one commit. I really need to see all of the changes in one commit so I don't have to merge everything in my head. b) I merge this PR, and then make the change myself in another commit. let me know how you want to proceed. |
@4t145 so, you want the option b) or a) ? |
I can merge all the commits into one, but if you are willing to implement those yourself, you can just merge this and modify it your self. Otherwise I will handle this tomorrow. Thanks for your work! |
72cd570
to
75c4320
Compare
@jeremychone Now you can review again. |
@4t145 Cool, will look at it tomorrow or Friday. |
@4t145 Ok, overall looks good. One thing, is that you added "client" to the I will merge this PR and fix it. Also, the property to get the content should be But otherwise, pretty good. I like the way you did |
I understand the confusion. You put it in ClientConfig, which is understandable. But we want this at the Chat Options level so hat we can override it per chat. |
… able to override it by chat request
@4t145 Done. So, now you set it at the ChatOptions level. Which can be set at the client level, or when making a request (and it will override) |
Remain original response body, so users can do provider specific operations.